LPS-9442 #6698
Closed
LPS-9442 #6698
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey Tomas, I merged some of this in, but not all. Please see my changes. The major issue I had was with PortalTilesDefinitionsFactory. See portal-impl/build.xml targets: build-icu4j, build-json-java. We should have one for build-tiles that will unzip the file, make the changes and recommit it. From a legal perspective, build.xml IS our source since we're just manipulating it... and we're showing exactly how. Can you rebase and resend? Thx. |
|
Please see #7403 Thank you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi Brian, I've cut it into isolated commits which can be applied one by one without breaking any functionality.