LRQA-57487 | master #87152
Closed
LRQA-57487 | master #87152
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…and ddm-form-builder
|
Closing pull request because all |
|
ci:reopen |
|
Merged. Thank you. |
brianchandotcom
pushed a commit
that referenced
this pull request
Apr 2, 2020
These tests were doubly disabled in: - #87152 - #87153 Root cause: These two modules, dynamic-data-mapping-form-builder and dynamic-data-mapping-form-web, are the only two places left in liferay-portal that we still use Metal's incremental-dom, which is incompatible with React. In f7704c1, we switched everything to assume React by default, but these two modules needed an explicit opt-out so that they could continue to use incremental-dom. All of this was fine until f18e7fe, which added a React-powered modal to frontend-js-web. This caused these DDM tests to fail because they depend on frontend-js-web, and as soon as they hit React JSX everything blows up because without the React preset, it is considered to be a syntax error. The fix is to selectively mock the `openModal` export from frontend-js-web to prevent the codepath that involves JSX from being exercised. Consider it a nasty hack, but a temporary one, because we will eventually get rid of all incremental-dom usage.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.liferay.com/browse/LRQA-57487