Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LPS-101620 Deprecate Liferay.Util.randomInt #87824

Closed
wants to merge 4 commits into from
Closed

LPS-101620 Deprecate Liferay.Util.randomInt #87824

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
da422d6
LPS-101620 Deprecate `Liferay.Util.randomInt`
Apr 20, 2020
621c8cd
LPS-101620 Update the deprecation comment for `Liferay.Util.randomInt`
Apr 20, 2020
6cdd934
LPS-101620 Use correct format for JSDoc comment
Apr 21, 2020
61b6f5a
LPS-101620 Fix JSDoc comment
Apr 21, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion modules/apps/archived/chat-web/src/main/resources/META-INF/resources/js/main.js
View file
Open in desktop
Expand Up @@ -33,7 +33,7 @@ AUI().use(

var Notification = Config.win.Notification;

var windowId = Liferay.Util.randomInt();
var windowId = Math.ceil(Math.random() * Number.MAX_SAFE_INTEGER);

var now = Date.now;

Expand Down
4 changes: 3 additions & 1 deletion ...apping/dynamic-data-mapping-web/src/main/resources/META-INF/resources/js/custom_fields.js
View file
Open in desktop
Expand Up @@ -872,7 +872,9 @@ AUI.add(
};

LiferayFieldSupport.prototype._randomString = function(length) {
var randomString = Liferay.Util.randomInt().toString(36);
var randomString = Math.ceil(
Math.random() * Number.MAX_SAFE_INTEGER
).toString(36);

return randomString.substring(0, length);
};
Expand Down
2 changes: 1 addition & 1 deletion ...s/frontend-js/frontend-js-aui-web/src/main/resources/META-INF/resources/liferay/poller.js
View file
Open in desktop
Expand Up @@ -17,7 +17,7 @@ AUI.add(
A => {
var AObject = A.Object;

var _browserKey = Liferay.Util.randomInt();
var _browserKey = Math.ceil(Math.random() * Number.MAX_SAFE_INTEGER);
var _enabled = false;
var _encryptedUserId = null;
var _supportsComet = false;
Expand Down
3 changes: 3 additions & 0 deletions ...pps/frontend-js/frontend-js-aui-web/src/main/resources/META-INF/resources/liferay/util.js
View file
Open in desktop
Expand Up @@ -918,6 +918,9 @@
document.all[id].focus();
},

/**
* @deprecated As of Athanasius (7.3.x), with no direct replacement
*/
randomInt() {
return Math.ceil(Math.random() * new Date().getTime());
},
Expand Down