LPS-116042 Update portal-search-elasticsearch6 app.bnd

[joshchong]

https://issues.liferay.com/browse/LPS-116042

[liferay-continuous-integration]

Closing pull request because all liferay-portal pullrequests sent to Brian Chan must be sent by using ci:forward on a pull request that was sent to someone else.

[joshchong]

ci:test:sf

[liferay-continuous-integration]

Closing pull request because all liferay-portal pullrequests sent to Brian Chan must be sent by using ci:forward on a pull request that was sent to someone else.

[joshchong]

@jpince Can you take a quick look at these changes? Two that I'm unsure of are Liferay-Releng-Deprecated and Liferay-Releng-Marketplace which I tried to set to true and false respectively but SF was complaining due to these rules: bnd_suite_check.markdown

If things look good, we can reopen this PR.

[jpince]

@joshchong looks good, I will reopen this pull.

Releng-Marketplace can continue to be true, no harm in that. This is kindof an obsolete property anyways.

Related to Releng-Deprecated, the Search team should have a separate conversation about what to do with the code:

1. The es6 modules will continue to be published, unless the team adds the .lfrbuild-releng-ignore file. This is not a problem for me and Brian Chan, but maybe Andre cares about this.
2. The es6 code could be moved to the archived folder, or just deleted. I think since we're upgrading to a new version and we don't plan on supporting es6 for 7.3, then no deprecation process is needed (either in app.bnd, archived folder, or anywhere else).

Let me know if you have any questions. Thanks again!

[joshchong]

ci:test:sf

[liferay-continuous-integration]

Closing pull request because all liferay-portal pullrequests sent to Brian Chan must be sent by using ci:forward on a pull request that was sent to someone else.

[joshchong]

ci:reopen

[joshchong]

ok got it thanks @jpince! FYI @arboliveira see Jason's comment above.

[jpince]

@joshchong just test with sf locally. On a quick glance, it looked ok, but never hurts to check :)

[joshchong]

@jpince haha yeah I did, but I just wanted to double check since sometimes results differ on CI. I ended up testing it in a self PR and it passed:
joshchong#325 (comment)

[brianchandotcom]

Merged. Thank you.
View total diff: 131008c...d22c081

[brianchandotcom]

@joshchong ok.. I'm merging, if things don't sync, please send me a revert.