LPS-121824/LPS-121466 #94886
Closed
LPS-121824/LPS-121466 #94886
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Closing pull request because all |
|
ci:reopen |
|
@brianchandotcom I reviewed the test result in Peter's pull, failure was an unrelated jenkins issue. Please merge with the other pulls for LPS-121842: |
|
Just started reviewing :) |
|
@petershin please review my changes for LPS-121824 in liferay-portal-ee 7.2.x, 7.1.x, and 7.0.x They were all a tiny bit different. Thx. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Manual forward: petershin#1246
LPS-121824: avoid chicken and egg scenario for the 7.4 changes in master-private
LPS-121466: fix regression on master
@jpince