Added auctions to API #31
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Btw, haven't checked if this will work with exotic realm names, with white space or russian characters. Let me add another unit test :). |
|
Nice! |
|
The .csproj has not be commited with the AH files included. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added auctions to the API + tests.
On a side note: To make testing more easier you could refactor the code abit to allow a different source where the data is coming from. Now it's bound to come from the web (WebClient), but if you allow local resources like a text file it reduces testing time and you are always sure of the same data. You are testing the parsing stuff mostly anyway :)