Option to filter Realms by locale #68
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Filtering realms by locale was not possible via ?locale=. Testing the URL in the browser brought in all cases all realms. Now the realms are filtered by an additional parameter. If it is set to Locale.None all realms will be returned.
|
Well I've not seen the difference by ?locale= as this is only the display language. |
I haven't seen that ?locale= changes the display language. I've thought that this one filters the realms by locale and returns only those matching it.
|
reviewing and building nuget update later this week. |
briandek
added a commit
that referenced
this pull request
Oct 31, 2015
Option to filter Realms by locale
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Filtering realms by locale was not possible via ?locale=.
Testing the URL in the browser brought in all cases all realms.
Now the realms are filtered by an additional parameter. If it is set to
Locale.None all realms will be returned.
Also added Locale and Battlegroup property.