MDE Device Id Enrichment #81
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I recall there was a reason was this wasn't done back in the day. But I can't seem to remember which one. |
|
@piaudonn wasn't it just the risk of picking the wrong device? Since there's no guarantee that the device name is unique? I feel like that risk is adequately addressed since this will prefer FQDN matches to hostname and if it fails to hostname it will only return the ID of there's no other device IDs with the same name reporting in the last 12h |
piaudonn
approved these changes
Jun 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the event a host entity is received without an MDE device ID, no effort was made to obtain one, so modules like MDE would not function on those host entities.
This change will do a best effort to lookup the device by FQDN and Hostname to return the MDE device id. FQDN matches are preferred over Hostname matches. In the event there is more than one device id found reporting in the last 12 hours with the same type of match (on FQDN or on hostname), we will not enrich since we don't know which device id to use. If any failure occurs running the query to get the MDE device id the base module will continue without the enrichment