cmp: read hex input with hex() #309

mknos · 2023-11-03T02:06:55Z

Hex and decimal offsets are permitted for arguments skip1 and skip2
eval() was being used but hex() is good enough
hex() can handle the "0x" prefix so we don't need to strip it

* Hex and decimal offsets are permitted for arguments skip1 and skip2 * eval() was being used but hex() is good enough * hex() can handle the "0x" prefix so we don't need to strip it

\d is locale-dependent and matches much more than we want.

cmp: read hex input with hex()

88b26fa

* Hex and decimal offsets are permitted for arguments skip1 and skip2 * eval() was being used but hex() is good enough * hex() can handle the "0x" prefix so we don't need to strip it

github-actions bot added Type: enhancement improve a feature that already exists Priority: low get to this whenever Program: cmp The cop program labels Nov 3, 2023

Restrict to decimal digits

c42f5c8

\d is locale-dependent and matches much more than we want.

briandfoy approved these changes Nov 3, 2023

View reviewed changes

briandfoy self-assigned this Nov 3, 2023

briandfoy merged commit 5f2bfba into briandfoy:master Nov 3, 2023
1 check passed

briandfoy temporarily deployed to merge November 3, 2023 22:17 — with GitHub Actions Inactive

briandfoy added Status: accepted The fix is accepted and removed Priority: low get to this whenever labels Nov 9, 2023

briandfoy added Status: released there is a new release with this fix and removed Status: accepted The fix is accepted labels Nov 24, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

cmp: read hex input with hex() #309

cmp: read hex input with hex() #309

mknos commented Nov 3, 2023

cmp: read hex input with hex() #309

cmp: read hex input with hex() #309

Conversation

mknos commented Nov 3, 2023