Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rev: terminate options with -- #439

Merged
merged 1 commit into from
Feb 5, 2024
Merged

rev: terminate options with -- #439

merged 1 commit into from
Feb 5, 2024

Conversation

mknos
Copy link
Contributor

@mknos mknos commented Feb 5, 2024

  • GNU and OpenBSD versions of rev use getopt(), so they support '--' for terminating options; add getopt() here too
  • Remove --help (-h); usage string is still printed
  • Update SYNOPSIS and usage() to indicate multiple input files can be processed
  • test1: "perl rev -- -v 01 02" --> 3 input files (now I can read file called "-v" without typing "./-v")
  • test2: "perl rev -x" --> bad option

@mknos
rev: terminate options with --
3866448 
* GNU and OpenBSD versions of rev use getopt(), so they support '--' for terminating options; add getopt() here too
* Remove --help (-h); usage string is still printed
* Update SYNOPSIS and usage() to indicate multiple input files can be processed
* test1: "perl rev -- -v 01 02" --> 3 input files
* test2: "perl rev -x" --> bad option
@github-actions github-actions bot added Type: enhancement improve a feature that already exists Priority: low get to this whenever Program: rev The rev program labels Feb 5, 2024
@briandfoy briandfoy self-assigned this Feb 5, 2024
@briandfoy briandfoy merged commit 8ac51b1 into briandfoy:master Feb 5, 2024
1 of 2 checks passed
@briandfoy briandfoy added Status: accepted The fix is accepted and removed Priority: low get to this whenever labels Feb 5, 2024
briandfoy added a commit that referenced this pull request Feb 5, 2024
@briandfoy
don't test long options (#439 moved to getopts)
643946c
@briandfoy
Copy link
Owner

changes: terminate args with --

@briandfoy briandfoy added Status: released there is a new release with this fix and removed Status: accepted The fix is accepted labels Mar 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@briandfoy briandfoy briandfoy approved these changes

Assignees

@briandfoy briandfoy

Labels
Program: rev The rev program Status: released there is a new release with this fix Type: enhancement improve a feature that already exists
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mknos @briandfoy