Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

id: don't ignore extra arguments #494

Merged
merged 1 commit into from
Mar 12, 2024
Merged

id: don't ignore extra arguments #494

merged 1 commit into from
Mar 12, 2024

Conversation

mknos
Copy link
Contributor

@mknos mknos commented Mar 11, 2024

  • This version of id follows BSD and only supports one user argument
  • Instead of ignoring extra arguments, print usage and exit as done by OpenBSD version
  • test1: valid usage: "perl id 0" --> display root user on my Linux system
  • test2: invalid usage: "perl id 0 0 0 0 0" --> previously did not raise error
  • test3: valid usage: "perl id" --> user taken as "current user"

@mknos
id: don't ignore extra arguments
64578e4 
* This version of id follows BSD and only supports one user argument
* Instead of ignoring extra arguments, print usage and exit as done by OpenBSD version
* test1: valid usage: "perl id 0" --> display root user on my Linux system
* test2: invalid usage: "perl id 0 0 0 0 0" --> previously did not raise error
* test3: valid usage: "perl id" --> user taken as "current user"
@github-actions github-actions bot added Type: enhancement improve a feature that already exists Priority: low get to this whenever Program: id The id program labels Mar 11, 2024
@briandfoy briandfoy self-assigned this Mar 12, 2024
@briandfoy
Copy link
Owner

changes: allow only 0 or 1 arguments

@briandfoy briandfoy merged commit fba7f95 into briandfoy:master Mar 12, 2024
2 checks passed
@briandfoy briandfoy added Status: accepted The fix is accepted and removed Priority: low get to this whenever labels Mar 12, 2024
@briandfoy briandfoy added Status: released there is a new release with this fix and removed Status: accepted The fix is accepted labels Apr 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@briandfoy briandfoy

Labels
Program: id The id program Status: released there is a new release with this fix Type: enhancement improve a feature that already exists
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mknos @briandfoy