Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

kill: list signals for bad sig name #513

Merged
merged 1 commit into from Mar 21, 2024
Merged

kill: list signals for bad sig name #513

merged 1 commit into from Mar 21, 2024

Conversation

mknos
Copy link
Contributor

@mknos mknos commented Mar 21, 2024

  • version1: bash: "builtin kill -h" --> "invalid signal specification" error
  • version2: GNU: "/usr/bin/kill -h" --> prints usage string
  • version3: pdksh: "builtin kill -h" --> "unknown option" error
  • version4: OpenBSD: "/bin/kill -h" --> "unknown signal" error, then print signal list
  • To me, version4 is the most helpful because it saves the user having to type "kill -l" to see the list
  • test1: "perl kill" --> no pid given; print usage
  • test2: "perl kill -h" --> print error, show signal list, exit(1)
  • test3: "perl kill -l" --> show signal list, exit(0)
  • test4: "perl kill 1" --> fails as expected because my user doesn't have permission to kill init process

@mknos
kill: list signals for bad sig name
832d130 
* version1: bash: "builtin kill -h" --> "invalid signal specification" error
* version2: GNU: "/usr/bin/kill -h" --> prints usage string
* version3: pdksh: "builtin kill -h" --> "unknown option" error
* version4: OpenBSD: "/bin/kill -h" --> "unknown signal" error, then print signal list
* To me, version4 is the most helpful because it saves the user having to type "kill -l" to see the list
* test1: "perl kill" --> no pid given; print usage
* test2: "perl kill -h" --> print error, show signal list, exit(1)
* test3: "perl kill -l" --> show signal list, exit(0)
* test4: "perl kill 1" --> fails as expected because my user doesn't have permission to kill init process
@github-actions github-actions bot added Type: enhancement improve a feature that already exists Priority: low get to this whenever Program: kill The kill program labels Mar 21, 2024
@briandfoy briandfoy merged commit 4823630 into briandfoy:master Mar 21, 2024
2 checks passed
@briandfoy briandfoy self-assigned this Mar 21, 2024
@briandfoy briandfoy added Status: accepted The fix is accepted and removed Priority: low get to this whenever labels Mar 21, 2024
@briandfoy
Copy link
Owner

changes: help shows signal list

@briandfoy briandfoy added Status: released there is a new release with this fix and removed Status: accepted The fix is accepted labels Apr 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@briandfoy briandfoy briandfoy approved these changes

Assignees

@briandfoy briandfoy

Labels
Program: kill The kill program Status: released there is a new release with this fix Type: enhancement improve a feature that already exists
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mknos @briandfoy