Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bc: forbid negative array index #521

Merged
merged 1 commit into from
Mar 25, 2024
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 9 additions & 5 deletions bin/bc
Original file line number Diff line number Diff line change
Expand Up @@ -2459,10 +2459,14 @@ sub exec_stmt
next INSTR;

} elsif($_ eq 'P') {

my $value = pop @ope_stack;
my $index = pop @ope_stack;
push @ope_stack, $value;
my $index = splice @ope_stack, -2, 1; # rval remains top of stack
if($index !~ /^\d+$/) {
print STDERR "Non-integer index $index for array\n";
$return = 3;
@ope_stack = ();
@stmt_list=();
last INSTR;
}
push @ope_stack, $instr->[1] . '[]' . $index;
next INSTR;

Expand All @@ -2489,7 +2493,7 @@ sub exec_stmt
$return = 3;
@ope_stack = ();
@stmt_list=();
YYERROR;
last INSTR;
}

# debug {"p: $name, $idx.\n"};
Expand Down
Loading