Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

awk: remove temporary files #525

Merged
merged 1 commit into from Mar 28, 2024
Merged

awk: remove temporary files #525

merged 1 commit into from Mar 28, 2024

Conversation

mknos
Copy link
Contributor

@mknos mknos commented Mar 28, 2024

  • awk wrapper doesn't clean up after itself and I am left with all these spam files... a2pin.6695 a2pout.6695 a2pin.6697 a2pout.6697 a2pin.6699 a2pout.6699 a2pin.6702 a2pout.6702 a2pin.6951 a2pout.6951 a2pin.6953 a2pout.6953
  • unlink before exit is better, whether or not the files are written in /tmp

@mknos
awk: remove temporary files
51c601a 
* awk wrapper doesn't clean up after itself and I am left with all these spam files...
a2pin.6695 a2pout.6695 a2pin.6697 a2pout.6697 a2pin.6699 a2pout.6699 a2pin.6702 a2pout.6702 a2pin.6951 a2pout.6951 a2pin.6953 a2pout.6953

* unlink before exit is better, whether or not the files are written in /tmp
@github-actions github-actions bot added Type: enhancement improve a feature that already exists Priority: low get to this whenever Program: awk The awk program labels Mar 28, 2024
@briandfoy
Copy link
Owner

briandfoy commented Mar 28, 2024 •
edited

Yeah, I noticed this when I was looking at your previous pull request. I'm happy that you went back to look at this.

A future fix might be to use File::Temp.

@briandfoy briandfoy self-assigned this Mar 28, 2024
@briandfoy briandfoy merged commit 279bf05 into briandfoy:master Mar 28, 2024
1 of 2 checks passed
@briandfoy briandfoy added Status: accepted The fix is accepted and removed Priority: low get to this whenever labels Mar 28, 2024
@briandfoy briandfoy added Status: released there is a new release with this fix and removed Status: accepted The fix is accepted labels Apr 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@briandfoy briandfoy briandfoy approved these changes

Assignees

@briandfoy briandfoy

Labels
Program: awk The awk program Status: released there is a new release with this fix Type: enhancement improve a feature that already exists
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mknos @briandfoy