Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

kill: validate pid #534

Merged
merged 1 commit into from
Apr 4, 2024
Merged

kill: validate pid #534

merged 1 commit into from
Apr 4, 2024

Conversation

mknos
Copy link
Contributor

@mknos mknos commented Apr 4, 2024

  • Avoid passing non-numeric pids to kill()
  • Printing "Can't kill a non-numeric process ID" is not helpful because kill can accept many pids and the error doesn't indicate which pid is bad; print a helpful error instead
  • This was found when testing against the bash-builtin kill

@mknos
kill: validate pid
d18dc05 
* Avoid passing non-numeric pids to kill()
* Printing "Can't kill a non-numeric process ID" is not helpful because kill can accept many pids and the error doesn't indicate which pid is bad
* This was found when testing against the bash-builtin kill
@github-actions github-actions bot added Type: enhancement improve a feature that already exists Priority: low get to this whenever Program: kill The kill program labels Apr 4, 2024
@briandfoy
Copy link
Owner

changes: pid must be a positive whole number

@briandfoy briandfoy merged commit 964afac into briandfoy:master Apr 4, 2024
1 of 2 checks passed
@briandfoy briandfoy added Status: accepted The fix is accepted and removed Priority: low get to this whenever labels Apr 4, 2024
@briandfoy briandfoy added Status: released there is a new release with this fix and removed Status: accepted The fix is accepted labels Apr 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@briandfoy briandfoy briandfoy approved these changes

Assignees
No one assigned
Labels
Program: kill The kill program Status: released there is a new release with this fix Type: enhancement improve a feature that already exists
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mknos @briandfoy