ed: input filename validation #542
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
mknos
commented
Apr 10, 2024
mknos
commented
- An empty filename (ed '') is incorrect usage and should show an error
- GNU ed attempts open() and fails; OpenBSD ed fails with "invalid filename" error and avoids open() (follow OpenBSD)
- In edEdit(), $filename could still be undefined in default case because $RememberedFilename is undefined when starting ed with empty buffer
- The code was a bit redundant because the value of $RememberedFilename was saved into itself again
- Save $RememberedFilename only if filename is taken from $args[0]
* An empty filename (ed '') is incorrect usage and should show an error * GNU ed attempts open() and fails; OpenBSD ed fails with "invalid filename" error and avoids open() (follow OpenBSD) * In edEdit(), $filename could still be undefined in default case because $RememberedFilename is undefined when starting ed with empty buffer * The code was a bit redundant because the value of $RememberedFilename was saved into itself again * Save $RememberedFilename only if filename is taken from $args[0]
github-actions
bot
added
Type: enhancement
briandfoy
approved these changes
Apr 10, 2024
|
changes: filename must have at least one character; better support to remember filename |
briandfoy
added
Status: accepted
briandfoy
added
Status: released
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.