ed: runtime error in edSubstitute() #577
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
mknos
commented
Apr 24, 2024
mknos
commented
- The program crashes when fed unexpected input after the initial "s" command
- I found this when investigating a capture-variable-outside-of-condition warning from perlcritic
- $char is the 1st character after the "s"; normally it would be "/" as in s/old/new/
- Return early if $args[0] is an empty string
- Adding eval guard around the confusing regex constructed from $char prevents the error
- Possibly the code could be changed later to enforce that $char is '/'
* The program crashes when fed unexpected input after the initial "s" command * I found this when investigating a capture-variable-outside-of-condition warning from perlcritic * $char is the 1st character after the "s"; normally it would be "/" as in s/old/new/ * Return early if $args[0] is an empty string * Adding eval guard around the confusing regex constructed from $char prevents the error * Possibly the code could be changed later to enforce that $char is '/' perl ed -p 'ed% ' a.c 63 ed% 1 #include <stdio.h> ed% s*asaaa* Unknown verb pattern '' in regex; marked by <-- HERE in m/((*) <-- HERE [^"*"]*(*)[^"*"]*(*)?)([imsx]*)/ at ed line 519, <> line 2.
github-actions
bot
added
Type: enhancement
briandfoy
approved these changes
Apr 24, 2024
|
changes: handle argument to |
briandfoy
added
Status: accepted
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.