Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pom: avoid using bad environment values #597

Merged
merged 2 commits into from
May 10, 2024
Merged

pom: avoid using bad environment values #597

merged 2 commits into from
May 10, 2024

Conversation

mknos
Copy link
Contributor

@mknos mknos commented May 10, 2024

  • Deliberate crash1: COLS=-1 perl pom -e Out of memory!
  • Deliberate crash2: LINES=-1 perl pom -e Can't take sqrt of -0.5625 at pom line 298.
  • For crash1 I noted the value of $terminal_width was 4294967292, i.e. sign-extension of -1
  • Avoid these errors by displaying a "bad terminal width" or "bad terminal height" error instead
  • Make use of checknum() which is already able to catch negative numbers, and other bad input
  • Extra change: convert aspect ratio to a constant

@mknos
pom: avoid using bad environment values
0592666 
* Deliberate crash1: COLS=-1 perl pom -e
Out of memory!
* Deliberate crash2: LINES=-1 perl pom -e
Can't take sqrt of -0.5625 at pom line 298.
* For crash1 I noted the value of $terminal_width was 4294967292, i.e. sign-extension of -1
* Avoid these errors by displaying a "bad terminal width" or "bad terminal height" error instead
* Make use of checknum() which is already able to catch negative numbers, and other bad input
* Extra change: convert aspect ratio to a constant
@github-actions github-actions bot added Type: enhancement improve a feature that already exists Priority: low get to this whenever Program: pom The pom program labels May 10, 2024
@briandfoy briandfoy merged commit b8af8e7 into briandfoy:master May 10, 2024
1 check passed
@briandfoy
Copy link
Owner

changes: ensure values for columns, rows, and terminal width make sense

@briandfoy briandfoy self-assigned this May 10, 2024
@briandfoy briandfoy added Status: accepted The fix is accepted and removed Priority: low get to this whenever labels May 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@briandfoy briandfoy briandfoy approved these changes

Assignees

@briandfoy briandfoy

Labels
Program: pom The pom program Status: accepted The fix is accepted Type: enhancement improve a feature that already exists
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mknos @briandfoy