Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ed: refactor command tree #598

Merged
merged 1 commit into from
May 22, 2024
Merged

ed: refactor command tree #598

merged 1 commit into from
May 22, 2024

Conversation

mknos
Copy link
Contributor

@mknos mknos commented May 10, 2024

  • Replace large if-else block with a more declarative lookup table
  • Some helper functions were needed for functions which implemented multiple commands (e.g. edHelp() implements 'h' and 'H')
  • Add missing default "else", i.e. print a warning if edParse() was successful but the handler didn't exist in cmdtab hash
  • No intended functional change, aside from the extra bad-command warning

@mknos
ed: refactor command tree
219fa41 
* Replace large if-else block with a more declarative lookup table
* Some helper functions were needed for functions which implemented multiple commands (e.g. edHelp() implements 'h' and 'H')
* Add missing default "else", i.e. print a warning if edParse() was successful but the handler didn't exist in cmdtab hash
* No intended functional change, aside from the extra bad-command warning
@github-actions github-actions bot added Type: enhancement improve a feature that already exists Priority: low get to this whenever Program: ed The ed program labels May 10, 2024
briandfoy
briandfoy approved these changes May 22, 2024
View reviewed changes
Copy link
Owner

@briandfoy briandfoy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a very pleasing change. Thanks,

@briandfoy briandfoy merged commit 2ee3449 into briandfoy:master May 22, 2024
2 checks passed
@briandfoy briandfoy self-assigned this May 22, 2024
@briandfoy briandfoy added Status: accepted The fix is accepted and removed Priority: low get to this whenever labels May 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@briandfoy briandfoy briandfoy approved these changes

Assignees

@briandfoy briandfoy

Labels
Program: ed The ed program Status: accepted The fix is accepted Type: enhancement improve a feature that already exists
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mknos @briandfoy