Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

install: remove -M flag #644

Merged
merged 2 commits into from
Jun 7, 2024
Merged

install: remove -M flag #644

merged 2 commits into from
Jun 7, 2024

Conversation

mknos
Copy link
Contributor

@mknos mknos commented Jun 6, 2024

  • The -M flag is a stub and was included for compatibility; however, version of install from GNU, Solaris[1] and OpenBSD do not support -M
  • -M was never mentioned in the usage string or SYNOPSIS but it can be removed entirely
  • NetBSD install has -M but it takes a value, so would not be compatible with this stub
  1. https://shrubbery.net/solaris9ab/SUNWaman/hman1b/install.1b.html

* The -M flag is a stub and was included for compatibility; however, version of install from GNU, Solaris[1] and OpenBSD do not support -M
* -M was never mentioned in the usage string or SYNOPSIS but it can be removed entirely
* NetBSD install has -M but it takes a value, so would not be compatible with this stub

1. https://shrubbery.net/solaris9ab/SUNWaman/hman1b/install.1b.html
@github-actions github-actions bot added Type: enhancement improve a feature that already exists Priority: low get to this whenever Program: install The install program labels Jun 6, 2024
bin/install Outdated
@@ -17,13 +17,16 @@ use strict;
use File::Basename qw(basename dirname);
use Getopt::Std qw(getopts);

my ($VERSION) = '1.3';
our $VERSION = '1.3';
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Update version now that a feature has been removed

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, committed.

@briandfoy briandfoy added the Status: changes requested adjust the pull request as noted in comments label Jun 6, 2024
@briandfoy briandfoy self-assigned this Jun 6, 2024
@briandfoy briandfoy merged commit 500ac57 into briandfoy:master Jun 7, 2024
1 check passed
@briandfoy briandfoy added Status: accepted The fix is accepted and removed Priority: low get to this whenever Status: changes requested adjust the pull request as noted in comments labels Jun 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Program: install The install program Status: accepted The fix is accepted Type: enhancement improve a feature that already exists
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants