Sort --head and --tail flags #65

shlomif · 2019-07-25T15:08:35Z

These use heaps/PQs to speed up the sort | head/tail idioms. A nonstandard feature that I prototyped in PPT.

coveralls · 2019-07-25T15:14:37Z

Pull Request Test Coverage Report for Build 56

0 of 0 changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 91.549%

Totals
Change from base Build 55:	0.0%
Covered Lines:	65
Relevant Lines:	71

💛 - Coveralls

briandfoy

We're stuck with core modules, so we can't pull from CPAN.

briandfoy · 2019-10-16T01:55:13Z

bin/sort

+    }
+    my $pq;
+    if (defined $head or defined $tail) {
+        require Heap::Fibonacci;


With PerlPowerTools, we have to be mostly self contained. If it's not in Perl core, we need to stay away from it.

I see. Well, these modules won't get used as long as the flags are not specified. This branch was also just a proof-of-concept for a similar feature in gnu coreutils or whatever. Feel free to close this pull req - https://www.shlomifish.org/philosophy/philosophy/putting-cards-on-the-table-2019-2020/putting-cards-on-the-table-2019-2020.raw.html#do_and_let_do__live_and_let_live and Hakuna Matata

See: briandfoy/PerlPowerTools#65 similar to sort | head -10 or sort | tail -10 but should be more efficient. ---- I hereby disclaim any implicit or explicit ownership of my changes in this changeset, and put them under a multiple licence consisting of your choice of one of more of: - The CC0 / Public Domain - https://creativecommons.org/choose/zero/ . - The MIT / Expat license - https://en.wikipedia.org/wiki/MIT_License - The default licence of your project - The https://en.wikipedia.org/wiki/GNU_Lesser_General_Public_License - version 2.1 or higher - The https://en.wikipedia.org/wiki/GNU_General_Public_License - version 2 or higher - Any licence in the 2018-Aug-27 popular licenses list of https://opensource.org/licenses - The https://en.wikipedia.org/wiki/Apache_License version 2.0 or later - The https://en.wikipedia.org/wiki/Artistic_License version 2.0 or later - The https://en.wikipedia.org/wiki/ISC_license - The https://opensource.org/licenses/BSD-2-Clause Crediting me will be nice, but not mandatory, and you can change the licence of the project without needing my permission.

See: briandfoy/PerlPowerTools#65 similar to "sort | head -10" or "sort | tail -10" but should be more efficient. ---- I hereby disclaim any implicit or explicit ownership of my changes in this changeset, and put them under a multiple licence consisting of your choice of one of more of: - The CC0 / Public Domain - https://creativecommons.org/choose/zero/ . - The MIT / Expat license - https://en.wikipedia.org/wiki/MIT_License - The default licence of your project - The https://en.wikipedia.org/wiki/GNU_Lesser_General_Public_License - version 2.1 or higher - The https://en.wikipedia.org/wiki/GNU_General_Public_License - version 2 or higher - Any licence in the 2018-Aug-27 popular licenses list of https://opensource.org/licenses - The https://en.wikipedia.org/wiki/Apache_License version 2.0 or later - The https://en.wikipedia.org/wiki/Artistic_License version 2.0 or later - The https://en.wikipedia.org/wiki/ISC_license - The https://opensource.org/licenses/BSD-2-Clause Crediting me will be nice, but not mandatory, and you can change the licence of the project without needing my permission.

See: briandfoy/PerlPowerTools#65 similar to sort | head -10 or sort | tail -10 but should be more efficient. ---- I hereby disclaim any implicit or explicit ownership of my changes in this changeset, and put them under a multiple licence consisting of your choice of one of more of: - The CC0 / Public Domain - https://creativecommons.org/choose/zero/ . - The MIT / Expat license - https://en.wikipedia.org/wiki/MIT_License - The default licence of your project - The https://en.wikipedia.org/wiki/GNU_Lesser_General_Public_License - version 2.1 or higher - The https://en.wikipedia.org/wiki/GNU_General_Public_License - version 2 or higher - Any licence in the 2018-Aug-27 popular licenses list of https://opensource.org/licenses - The https://en.wikipedia.org/wiki/Apache_License version 2.0 or later - The https://en.wikipedia.org/wiki/Artistic_License version 2.0 or later - The https://en.wikipedia.org/wiki/ISC_license - The https://opensource.org/licenses/BSD-2-Clause Crediting me will be nice, but not mandatory, and you can change the licence of the project without needing my permission.

Refactoring / code cleanup. See: * https://en.wikipedia.org/wiki/Code_refactoring * https://www.refactoring.com/ * https://www.joelonsoftware.com/2002/01/23/rub-a-dub-dub/ Some small optimisations may have slipped in as well. See: briandfoy/PerlPowerTools#65 ----- The flags are similar to sort | head -10 or sort | tail -10 but should be more efficient. ---- I hereby disclaim any implicit or explicit ownership of my changes in this changeset, and put them under a multiple licence consisting of your choice of one of more of: - The CC0 / Public Domain - https://creativecommons.org/choose/zero/ . - The MIT / Expat license - https://en.wikipedia.org/wiki/MIT_License - The default licence of your project - The https://en.wikipedia.org/wiki/GNU_Lesser_General_Public_License - version 2.1 or higher - The https://en.wikipedia.org/wiki/GNU_General_Public_License - version 2 or higher - Any licence in the 2018-Aug-27 popular licenses list of https://opensource.org/licenses - The https://en.wikipedia.org/wiki/Apache_License version 2.0 or later - The https://en.wikipedia.org/wiki/Artistic_License version 2.0 or later - The https://en.wikipedia.org/wiki/ISC_license - The https://opensource.org/licenses/BSD-2-Clause Crediting me will be nice, but not mandatory, and you can change the licence of the project without needing my permission.

See: briandfoy/PerlPowerTools#65 similar to "sort | head -10" or "sort | tail -10" but should be more efficient. ---- I hereby disclaim any implicit or explicit ownership of my changes in this changeset, and put them under a multiple licence consisting of your choice of one of more of: - The CC0 / Public Domain - https://creativecommons.org/choose/zero/ . - The MIT / Expat license - https://en.wikipedia.org/wiki/MIT_License - The default licence of your project - The https://en.wikipedia.org/wiki/GNU_Lesser_General_Public_License - version 2.1 or higher - The https://en.wikipedia.org/wiki/GNU_General_Public_License - version 2 or higher - Any licence in the 2018-Aug-27 popular licenses list of https://opensource.org/licenses - The https://en.wikipedia.org/wiki/Apache_License version 2.0 or later - The https://en.wikipedia.org/wiki/Artistic_License version 2.0 or later - The https://en.wikipedia.org/wiki/ISC_license - The https://opensource.org/licenses/BSD-2-Clause Crediting me will be nice, but not mandatory, and you can change the licence of the project without needing my permission.

See: briandfoy/PerlPowerTools#65 similar to sort | head -10 or sort | tail -10 but should be more efficient. ---- I hereby disclaim any implicit or explicit ownership of my changes in this changeset, and put them under a multiple licence consisting of your choice of one of more of: - The CC0 / Public Domain - https://creativecommons.org/choose/zero/ . - The MIT / Expat license - https://en.wikipedia.org/wiki/MIT_License - The default licence of your project - The https://en.wikipedia.org/wiki/GNU_Lesser_General_Public_License - version 2.1 or higher - The https://en.wikipedia.org/wiki/GNU_General_Public_License - version 2 or higher - Any licence in the 2018-Aug-27 popular licenses list of https://opensource.org/licenses - The https://en.wikipedia.org/wiki/Apache_License version 2.0 or later - The https://en.wikipedia.org/wiki/Artistic_License version 2.0 or later - The https://en.wikipedia.org/wiki/ISC_license - The https://opensource.org/licenses/BSD-2-Clause Crediting me will be nice, but not mandatory, and you can change the licence of the project without needing my permission.

Refactoring / code cleanup. See: * https://en.wikipedia.org/wiki/Code_refactoring * https://www.refactoring.com/ * https://www.joelonsoftware.com/2002/01/23/rub-a-dub-dub/ Some small optimisations may have slipped in as well. See: briandfoy/PerlPowerTools#65 ----- The flags are similar to sort | head -10 or sort | tail -10 but should be more efficient. ---- I hereby disclaim any implicit or explicit ownership of my changes in this changeset, and put them under a multiple licence consisting of your choice of one of more of: - The CC0 / Public Domain - https://creativecommons.org/choose/zero/ . - The MIT / Expat license - https://en.wikipedia.org/wiki/MIT_License - The default licence of your project - The https://en.wikipedia.org/wiki/GNU_Lesser_General_Public_License - version 2.1 or higher - The https://en.wikipedia.org/wiki/GNU_General_Public_License - version 2 or higher - Any licence in the 2018-Aug-27 popular licenses list of https://opensource.org/licenses - The https://en.wikipedia.org/wiki/Apache_License version 2.0 or later - The https://en.wikipedia.org/wiki/Artistic_License version 2.0 or later - The https://en.wikipedia.org/wiki/ISC_license - The https://opensource.org/licenses/BSD-2-Clause Crediting me will be nice, but not mandatory, and you can change the licence of the project without needing my permission.

See: briandfoy/PerlPowerTools#65 similar to "sort | head -10" or "sort | tail -10" but should be more efficient. reformat with rustfmt fix cargo-clippy warnings ---- I hereby disclaim any implicit or explicit ownership of my changes in this changeset, and put them under a multiple licence consisting of your choice of one of more of: - The CC0 / Public Domain - https://creativecommons.org/choose/zero/ . - The MIT / Expat license - https://en.wikipedia.org/wiki/MIT_License - The default licence of your project - The https://en.wikipedia.org/wiki/GNU_Lesser_General_Public_License - version 2.1 or higher - The https://en.wikipedia.org/wiki/GNU_General_Public_License - version 2 or higher - Any licence in the 2018-Aug-27 popular licenses list of https://opensource.org/licenses - The https://en.wikipedia.org/wiki/Apache_License version 2.0 or later - The https://en.wikipedia.org/wiki/Artistic_License version 2.0 or later - The https://en.wikipedia.org/wiki/ISC_license - The https://opensource.org/licenses/BSD-2-Clause Crediting me will be nice, but not mandatory, and you can change the licence of the project without needing my permission.

Shlomi Fish added 13 commits July 25, 2019 17:09

Add a test for multiple -k in sort.

e611cbc

Merged.

c5eb8b6

Convert --head to use a heap.

a153f9a

avoid dep on Heap::Elem.

45712e9

Add docs.

abd6b70

enhance MANIFEST.SKIP.

82898a1

optimize.

a2e277c

optimisation.

90e16a2

apply optimization

6d51704

apply optimization

10aeb4d

apply optimization

b3b87e1

skip tests on missing deps.

5aaa66e

Add the --tail flag.

73fa918

briandfoy reviewed Oct 16, 2019

View reviewed changes

briandfoy closed this Oct 28, 2019

briandfoy self-assigned this Jul 11, 2023

briandfoy added Type: enhancement improve a feature that already exists Program: sort The sort program Status: released there is a new release with this fix labels Jul 11, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Sort --head and --tail flags #65

Sort --head and --tail flags #65

shlomif commented Jul 25, 2019

coveralls commented Jul 25, 2019 •

edited

briandfoy left a comment

briandfoy Oct 16, 2019

shlomif Oct 26, 2019

Sort --head and --tail flags #65

Sort --head and --tail flags #65

Conversation

shlomif commented Jul 25, 2019

coveralls commented Jul 25, 2019 • edited

Pull Request Test Coverage Report for Build 56

💛 - Coveralls

briandfoy left a comment

Choose a reason for hiding this comment

briandfoy Oct 16, 2019

Choose a reason for hiding this comment

shlomif Oct 26, 2019

Choose a reason for hiding this comment

coveralls commented Jul 25, 2019 •

edited