Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix multiple filenames in ARGV in tac with a test. #66

Closed
wants to merge 3 commits into from

Conversation

shlomif
Copy link
Contributor

@shlomif shlomif commented Aug 17, 2019

There was a mix of sysseek and tell.

There was a mix of sysseek and tell.
@coveralls
Copy link

coveralls commented Aug 17, 2019

Pull Request Test Coverage Report for Build 73

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.1%) to 91.667%

Totals Coverage Status
Change from base Build 69: 0.1%
Covered Lines: 66
Relevant Lines: 72

💛 - Coveralls

Copy link
Owner

@briandfoy briandfoy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The license needs to match the entire project.


__END__

=head1 COPYRIGHT & LICENSE
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You need to license everything in the same way that the entire package is licenses. In this case, it's exactly the Artistic License 2.0 (as seen in LICENSE). It can't be a future license that does not exist.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hi @briandfoy ! I hope you don't take it the wrong way but you seem a little too pedantic and stubborn and bikeshedding here - see http://shlomifishswiki.branchable.com/Never_Try_to_Please_Everyone/ . While IANAL but it is not inconceivable that one day there will be The Artistic License 2.1 or 3.0 or whatever. You can be a bit more tolerant. Hakuna matata .

@briandfoy
Copy link
Owner

Okay. I’ll close this issue. Since you decided to make personal attacks, I won’t accept any further contributions from you.

@briandfoy briandfoy closed this Oct 28, 2019
Repository owner deleted a comment from shlomif Mar 31, 2020
@briandfoy briandfoy added Type: bug an existing feature does not work Program: tac The tac program labels Jul 11, 2023
@briandfoy briandfoy self-assigned this Jul 11, 2023
@briandfoy briandfoy added the Status: released there is a new release with this fix label Jul 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Program: tac The tac program Status: released there is a new release with this fix Type: bug an existing feature does not work
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants