Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doesn't work with Perl 5.12 package NAME VERSION declarations #2 #5

Merged
merged 7 commits into from Oct 12, 2016
Merged

Doesn't work with Perl 5.12 package NAME VERSION declarations #2 #5

merged 7 commits into from Oct 12, 2016

Conversation

andrey-starodubtsev
Copy link
Contributor

No description provided.

@coveralls
Copy link

coveralls commented Oct 6, 2016

Coverage Status

Changes Unknown when pulling bf62556 on andrey-starodubtsev:perl-5.12-version into * on briandfoy:master*.

@andrey-starodubtsev
Copy link
Contributor Author

Made this module pass on perl 5.18-5.22, all changes from PR have nothing to do with fails on earlier perls. It looks like problem inside older versions of Safe.pm, or cover, or test harness - make test works OK, but cover -test fails.

@coveralls
Copy link

coveralls commented Oct 8, 2016

Coverage Status

Changes Unknown when pulling bfc9d9b on andrey-starodubtsev:perl-5.12-version into * on briandfoy:master*.

@briandfoy briandfoy merged commit b9c66b0 into briandfoy:master Oct 12, 2016
@briandfoy
Copy link
Owner

briandfoy commented Oct 12, 2016

Good work! Thanks!

But, now we need to support the PACKAGE NAME VERSION BLOCK stuff. I don't think this works for that yet.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants