Make git depend less on human-readable output #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Debian version of Git respects the locale, which ends up confusing Git.pm as it looks for "# On branch ..." , where my German localized version of Git outputs "Auf Zweig ..." . The two changes change the following: 1) Use the short status of git This only outputs a list of pending changes. If that list is not empty, we want to bail. 2) Use `git rev-parse --abbrev-ref HEAD` to find the current branch. https://stackoverflow.com/questions/6245570/how-to-get-current-branch-name-in-git suggests that is is the best way of finding the currently active branch. Thanks for maintaining Module::Release and Module::Release::Git!
|
Yes, we should make this change. I'll have to check out the Travis test failures, but after than it will be in the next release. Thanks, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Debian version of Git respects the locale, which ends up confusing Git.pm as it looks for "# On branch ..." , where my German localized version of Git outputs "Auf Zweig ..." . The two changes change the following:
This only outputs a list of pending changes. If that list is not empty, we want to bail.
git rev-parse --abbrev-ref HEADto find the current branch.https://stackoverflow.com/questions/6245570/how-to-get-current-branch-name-in-git suggests that is
is the best way of finding the currently active branch.
Thanks for maintaining Module::Release and Module::Release::Git!