Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Patches to allow for positional parameters #10

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

briandfoy
Copy link
Owner

I received these patches through email and the author does not want to participate in GitHub. No big whoop.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 5798401696

  • 50 of 83 (60.24%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-24.9%) to 62.105%

Changes Missing Coverage Covered Lines Changed/Added Lines %
lib/String/Sprintf.pm 50 83 60.24%
Totals Coverage Status
Change from base Build 3823129278: -24.9%
Covered Lines: 59
Relevant Lines: 95

💛 - Coveralls

@briandfoy briandfoy added Type: enhancement improve a feature that already exists Status: stalled something is blocking progress Priority: low get to this whenever labels Aug 8, 2023
@briandfoy
Copy link
Owner Author

This patch rewrites a lot of the module and is incompatible with the interface that the current version exposes. As such, these sorts of changes would have to be part of a major version upgrade. Even then, I wouldn't want to break everything already using this module.

I'll have to think about this for a bit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Priority: low get to this whenever Status: stalled something is blocking progress Type: enhancement improve a feature that already exists
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants