-
Notifications
You must be signed in to change notification settings - Fork 440
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Exception does not propegate to the client from the server (InvocationTargetException) #33
Comments
I have the same issue too!! |
…Service. When CompositeService is being used, the exception gets wrapped 2 times. Changing the if to while when unwrapping causes the exception to be well unwrapped.
I think I've solved the issue. The problem was when using CompositeService. It wraps the exeption thrown two times, and then it gets unwrapped only one time. The fix is here: |
…eService. When CompositeService is being used, the exception gets wrapped 2 times. Changing the if to while when unwrapping causes the exception to be well unwrapped.
Thank you, I encountered the same problem and the fix solved it for me. I commented on the fix conversation - I'd love to see this merged to brian's branch, I would greatly appreciate his feedback. Thanks |
Can we apply the pull request? |
I would also love to see this patch merged to upstream. |
@briandilley, any progress on this? |
This has been merged in. Unfortunatly no release since then, but around the end of the month I'll aim for a new release (1.2.0?). |
Awesome! |
When I throw a RuntimeException from the server it does not fully extract the source exception and such sends an InvocationTargetException to the client. However, this cannot be instantianated, so the client throws:
Here's a quick test project (https://github.com/gaborbernat/json4j-rpc-test). You need to run:
./gradlew server:appRun
./gradlew client:run
Any ideas what's wrong and how to fix it?
Thanks,
The text was updated successfully, but these errors were encountered: