Skip to content

Commit

Permalink
Fix CRAN check notes
Browse files Browse the repository at this point in the history
Had to deal with column names being created as part of the `gather()` operation.
  • Loading branch information
briandk committed Nov 22, 2023
1 parent 4cad694 commit 9a62d35
Show file tree
Hide file tree
Showing 3 changed files with 6 additions and 13 deletions.
1 change: 0 additions & 1 deletion .Rbuildignore
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,6 @@ roxygen.R
granovaGG.Rproj
README.m*
cran-comments.md
LICENSE

^.*\.Rproj$

Expand Down
2 changes: 1 addition & 1 deletion DESCRIPTION
Original file line number Diff line number Diff line change
Expand Up @@ -82,6 +82,7 @@ Description: create what we call Elemental Graphics for display of
files for individual functions.
URL: https://github.com/briandk/granovaGG
BugReports: https://github.com/briandk/granovaGG/issues
License: MIT + file LICENSE
Depends:
R (>= 2.14.0),
Imports:
Expand All @@ -102,4 +103,3 @@ Collate:
'granovagg.1w.R'
'granovagg.contr.R'
'granovagg.ds.R'
License: MIT + file LICENSE
16 changes: 5 additions & 11 deletions R/granovagg.contr.R
Original file line number Diff line number Diff line change
Expand Up @@ -323,8 +323,8 @@ granovagg.contr <- function(data,
raw.data <- RenameSummaryColumnNames(raw.data)
raw.data <- tidyr::gather(
raw.data,
key = contrast_number,
value = score
key = "contrast_number",
value = "score"
)
summary.data <- GetGroupSummary(raw.data)

Expand All @@ -351,10 +351,10 @@ granovagg.contr <- function(data,
standard.deviation <- NULL

output <- data %>%
dplyr::group_by(contrast_number) %>%
dplyr::group_by(.data$contrast_number) %>%
dplyr::summarise(
group.mean = mean(score),
standard.deviation = sd(score),
group.mean = mean(.data$score),
standard.deviation = sd(.data$score),
pooled.standard.deviation = mean(standard.deviation)^0.5
)
return(output)
Expand Down Expand Up @@ -438,12 +438,6 @@ granovagg.contr <- function(data,
return(output)
}

OptionalPlotPrinting <- function(output) {
if (print.four.plots.per.page) {
LayoutFourPlotsPerPage(output)
}
}

PrintOutput <- function() {
PrintLinearModelSummary(ctr$linear.model)
PrintSummaryDataByContrast(ctr)
Expand Down

0 comments on commit 9a62d35

Please sign in to comment.