Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

patching for rails 4 #2

Closed
wants to merge 1 commit into from
Closed

patching for rails 4 #2

wants to merge 1 commit into from

Conversation

j-miyake
Copy link

  • I replaced find_all_by_xxxxxx with where to let Rails4 projects can use this gem.
  • I fixed the way to get the foreign keys to let custom foreign keys be used.

@rafaelrpbelo
Copy link

@johnny-miyake I see you are using reflection instead to constantize the key given.
Your patch enables us to use a through association with a custom class name?

@j-miyake
Copy link
Author

Umm... I forgot why I made this pr, but maybe yes. As this repo seems to be no longer maintained, I'm closing this pr.

@j-miyake j-miyake closed this Apr 19, 2019
@j-miyake j-miyake deleted the patching_for_rails_4 branch April 19, 2019 01:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants