Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added missing Visibility field on CurrentWeatherData struct and changed the URL to HTTPS #100

Merged
merged 2 commits into from
Mar 25, 2022

Conversation

0ry0n
Copy link
Contributor

@0ry0n 0ry0n commented Mar 25, 2022

No description provided.

@0ry0n 0ry0n changed the title Added missing Visibility field on CurrentWeatherData struct Added missing Visibility field on CurrentWeatherData struct and changed the URL to HTTPS Mar 25, 2022
@briandowns
Copy link
Owner

Thank you for this update. I don't have a moment to test this right now but can you verify there is no regressions when changing all URLs to https?

@0ry0n
Copy link
Contributor Author

0ry0n commented Mar 25, 2022

I have run some tests and it seems to work fine

@0ry0n
Copy link
Contributor Author

0ry0n commented Mar 25, 2022

base, icon, forecast seem to work correctly

@briandowns
Copy link
Owner

Cool. Thanks!

@briandowns briandowns merged commit 0d6745a into briandowns:master Mar 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants