Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

timeoutMultiplier has been removed. #121

Merged
merged 1 commit into from Mar 7, 2019

Conversation

hiaw
Copy link
Contributor

@hiaw hiaw commented Mar 7, 2019

timeoutMultiplier has been removed. This will have the same behaviour

flutter/flutter#28811

@mmcc007
Copy link
Collaborator

mmcc007 commented Mar 7, 2019

Thanks for the PR!

It's currently running on Flutter v1.0.0 so it will probably timeout on integration tests.
If you upgrade to latest (v1.2.1) there's a good chance it will not timeout.

You can upgrade (in three places) in .travis.yml

@hiaw hiaw force-pushed the dc/flutter-driver-timeout branch from 59bc2fb to f30b5e1 Compare March 7, 2019 01:43
@codecov
Copy link

codecov bot commented Mar 7, 2019

Codecov Report

Merging #121 into master will decrease coverage by 0.63%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #121      +/-   ##
==========================================
- Coverage   62.69%   62.06%   -0.64%     
==========================================
  Files         139      140       +1     
  Lines        3048     3221     +173     
==========================================
+ Hits         1911     1999      +88     
- Misses       1137     1222      +85
Impacted Files Coverage Δ
todos_repository_simple/lib/src/web_client.dart 8.33% <0%> (-16.67%) ⬇️
mvi_base/lib/src/mvi_todo.dart 83.33% <0%> (-16.67%) ⬇️
built_redux/lib/models/app_tab.g.dart 64.28% <0%> (-10.72%) ⬇️
mvu/lib/common/repository_commands.dart 87.5% <0%> (-9.73%) ⬇️
mvi_base/lib/src/mvi_todos_list.dart 76.19% <0%> (-8.03%) ⬇️
blocs/lib/src/uuid.dart 92.3% <0%> (-7.7%) ⬇️
mvi_base/lib/src/uuid.dart 92.3% <0%> (-7.7%) ⬇️
simple_blocs/lib/src/uuid.dart 92.3% <0%> (-7.7%) ⬇️
built_redux/lib/data/web_client.dart 3.12% <0%> (-6.25%) ⬇️
built_redux/lib/models/visibility_filter.g.dart 61.11% <0%> (-5.56%) ⬇️
... and 37 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a9339cc...dc062b6. Read the comment docs.

@hiaw hiaw force-pushed the dc/flutter-driver-timeout branch from f30b5e1 to dc062b6 Compare March 7, 2019 02:54
@mmcc007 mmcc007 merged commit 0d04756 into brianegan:master Mar 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants