Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Example fix: Set the type of the store #4

Merged
merged 1 commit into from
Jan 26, 2018
Merged

Example fix: Set the type of the store #4

merged 1 commit into from
Jan 26, 2018

Conversation

btastic
Copy link
Contributor

@btastic btastic commented Jan 24, 2018

Hey there,

I just watched your talk on the dart conference. Great job! I was eager to try out your library and went straight to the examples when I stumbled on this part of the code:

final store = new Store(counterReducer, initialState: 0);

I am not sure if this is because of the new Dart SDK dart2.0.0-dev.16.0, but the line is causing the following warning:

[dart] A function of type '(int, Object) → int' can't be assigned to a variable of type '(dynamic, dynamic) → dynamic'.

I just went ahead and fixed the sample, it is a small contribution, but I think others that are new to the library will be less confused than I was.

@codecov
Copy link

codecov bot commented Jan 24, 2018

Codecov Report

Merging #4 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master       #4   +/-   ##
=======================================
  Coverage   95.58%   95.58%           
=======================================
  Files           1        1           
  Lines          68       68           
=======================================
  Hits           65       65           
  Misses          3        3

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bfb75a1...90a0717. Read the comment docs.

@brianegan
Copy link
Owner

Hey, glad ya liked the talk :) Thanks so much for the fix!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants