[core] Add the RandomDiscreteTimestampGenerator to generate a range of #1004
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
risdenk
approved these changes
Aug 10, 2017
| break; | ||
| case DAYS: | ||
| currentTimestamp = (System.currentTimeMillis() / 1000) + | ||
| getOffset(intervalOffset); | ||
| startTimestamp = currentTimestamp; |
There was a problem hiding this comment.
nit: could do this startTimestamp = currentTimestamp could go right before the return after the switch/case
There was a problem hiding this comment.
good point, cleaned it up. Thanks!
timestamps in a non-repeating random order. Modify UnixEpochTimestampGenerator so that the random generator can extend it.
|
Merged in b945c66, thanks! |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
timestamps in a non-repeating random order.
Modify UnixEpochTimestampGenerator so that the random generator can
extend it.