Port ycsb to Python3 and also make it Python2 compatible #1421
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Is someone planning to merge this? |
|
Hi @busbey, PTAL. |
|
I am planning to merge 1 of the several python updates. |
|
@busbey what's the ETA for this Python 3 update? |
|
providing a review will reduce the time it takes me to merge things. |
This was referenced Apr 13, 2022
uscxiexing
approved these changes
Oct 22, 2022
|
I'm excited about this Py3 support, thanks for putting it together! Is there anything that I or others could do to contribute / help it along? There's an ask for a review in the comments above, and a subsequent LGTM and approval. |
|
will be great to have this merged. what is needed for the review? |
prasannasvenkat
approved these changes
Aug 14, 2023
yoheia
pushed a commit
to yoheia/YCSB
that referenced
this pull request
Sep 21, 2023
|
Can you please merge this? |
|
Two months and no updates on this!! No Linux distro is shipping Python2, folks! Come on, please!! @busbey |
|
Yeah, please merge this. I have also tested this patch works fine with python3. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Python2 has reached EOL, so we should port the ycsb to Python3.
The modification also makes the ycsb Python2 compatible.