[mongodb] Add support for connecting to mongodb domain sockets #1587
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…in sockets Presently when trying to connect to a Mongodb instace exposed as a unix domain socket (e.g mongodb://run/mongodb/mongodb-<pid>.sock) following exception is reported: Exception in thread "Thread-3" java.lang.NoClassDefFoundError: jnr/unixsocket/UnixSocketAddress at com.mongodb.internal.connection.ServerAddressHelper.createServerAddress(ServerAddressHelper.java:31) <snip/> Caused by: java.lang.ClassNotFoundException: jnr.unixsocket.UnixSocketAddress at java.net.URLClassLoader.findClass(URLClassLoader.java:382) <snip/> This is caused by missing runtime dependencies of jnr-unixsocket (https://github.com/jnr/jnr-unixsocket) , jnr-ffi (https://github.com/jnr/jnr-ffi) and jnr-constants (https://github.com/jnr/jnr-constants). These dependencies lets the mongodb plugin connect to an db-instance via unix domain socket. Hence this change adds these dependencies to mongodb plugin's pom.xml as runtime scoped dependencies.
…ile scoped get_classpath_from_maven() generates the runtime classpath of a plugin by calling maven's dependency:build-classpath plugin to list all the jar files needed in compile scoped jar files. This might not always be correct since plugins like mongodb may have some runtime dependencies which may cause thier invocation to fail. One such exception was seen when mongodb plugin was trying to connect to an instance exposed a Unix domain socket which needs jnr-unixsocket dependency at runtime rather than at compile time. Hence passing the '-DincludeScope=compile' is not a correct choice in such a case. The exception thrown was similar to one below: INFO: Exception in monitor thread while connecting to server /run/mongodb/mongodb-27017.sock com.mongodb.MongoException: java.lang.UnsatisfiedLinkError: could not load FFI provider jnr.ffi.provider.jffi.Provider at com.mongodb.internal.connection.InternalStreamConnection.open(InternalStreamConnection.java:138) at com.mongodb.internal.connection.DefaultServerMonitor$ServerMonitorRunnable.run(DefaultServerMonitor.java:117) at java.lang.Thread.run(Thread.java:748) Caused by: java.lang.UnsatisfiedLinkError: could not load FFI provider jnr.ffi.provider.jffi.Provider at jnr.ffi.provider.InvalidRuntime.newLoadError(InvalidRuntime.java:102) <snip/> Caused by: java.lang.UnsatisfiedLinkError: could not get native definition for type `POINTER`, original error message follows: java.lang.UnsatisfiedLinkError: could not locate stub library in jar file. Tried [jni/ppc64le-Linux/libjffi-1.2.so, /jni/ppc6 4le-Linux/libjffi-1.2.so] at com.kenai.jffi.internal.StubLoader.getStubLibraryStream(StubLoader.java:577) at com.kenai.jffi.internal.StubLoader.loadFromJar(StubLoader.java:432) at com.kenai.jffi.internal.StubLoader.load(StubLoader.java:326) at com.kenai.jffi.internal.StubLoader.<clinit>(StubLoader.java:614) <snip/> To fix this the patch updates get_classpath_from_maven() to remove the '-DincludeScope=compile' arg from the maven command-line which should force maven to dependency:build-classpath plugin to list all compile and runtime scoped dependencies for the given plugin.
vaibhav92
force-pushed
the
mongodb-domain-sockets
branch
from
37c3807
to
fb2555a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These two commit lets YCSB connect to a mongodb instance thats exposed as a Unix domain socket like "mongodb://run/mongodb/mongodb-.sock" . Presently this functionality is broken due to some missing dependencies and the way get_classpath_from_maven() generates the classpath from maven's dependency:build-classpath plugin.
These two commits adds the needed runtime dependencies for mongodb plugin to be able to connect to a Unix domain socket and also updates get_classpath_from_maven() so that it can correctly identify these runtime dependencies and generates correct classpath to invoke the mongodb plugin.