[jdbc] added LIMIT to JDBC scan operation #468
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now properly enforcing a scan of the given number of documents in the scan operation using the LIMIT modifier in the cached statement. Fixes brianfrankcooper#171.
|
I think to fulfill the intent of the scan operation there should be some ordering. Workload E (which uses scans) describes:
Allowing the DB to return, say, any record from the latter half of the database doesn't seem to match that intent. |
|
Also, from the original YCSB paper:
|
This will ensure record ordering my the primary key.
|
OK, added an ORDER BY clause to ensure record ordering by the primary key. |
|
Looks good to me. @cmccoy - Any other concerns. |
|
Looks good. Thanks! |
cmccoy
added a commit
that referenced
this pull request
Nov 3, 2015
[jdbc] added LIMIT to JDBC scan operation
This was referenced Dec 15, 2015
jaricftw
pushed a commit
to jaricftw/YCSB
that referenced
this pull request
Jul 19, 2016
[jdbc] added LIMIT to JDBC scan operation
jaricftw
pushed a commit
to jaricftw/YCSB
that referenced
this pull request
Jul 19, 2016
[jdbc] added LIMIT to JDBC scan operation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now properly enforcing a scan of the given number of documents in the
scan operation using the LIMIT modifier in the cached statement.
Fixes #171.