Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for installating with Homebrew #13

Open
Odame opened this issue Aug 10, 2021 · 8 comments · Fixed by Homebrew/homebrew-cask#162690
Open

Support for installating with Homebrew #13

Odame opened this issue Aug 10, 2021 · 8 comments · Fixed by Homebrew/homebrew-cask#162690

Comments

@Odame
Copy link

Odame commented Aug 10, 2021

Feature Request

This is a great piece of software - nice job done ✌🏾.
In addition to the existing coolness, it will be nice if this application supports installation via homebrew.

@briankendall
Copy link
Owner

I've never packaged up an app for installation via Homebrew before. This app might make more sense for homebrew cask, but I'm not sure. I may get around to it eventually, but if someone else wants to set that up, I'm happy to assist by doing whatever work is necessary on my end.

@Odame
Copy link
Author

Odame commented Aug 11, 2021

Yeah, a homebrew cask is definitely the right way to go in that regard.
I too, don't have experience with packaging for Homebrew. But I will take a look at homebrew and see if I can pull this off - unless someone else with prior experience wants to take this up.

@MartinMajewski
Copy link

I also like the homebrew approach, as it is the more modern and most popular way nowadays.

@ian-h-chamberlain
Copy link

Btw, looks like this just got added to homebrew-cask now: Homebrew/homebrew-cask#155006

It seems to just install the .app though, and not the driver (nor does it kickstart coreaudiod). Seems there are probably some helpers that could be added to the cask to make it work, although they seem to be missing one for Audio/Plug-Ins/HAL. I don't have much experience either but maybe @chenrui333 knows what to do since they opened the original PR.

@mahmoudhossam
Copy link

I've been bitten by the issue @ian-h-chamberlain mentioned, the cask does not install the driver at all.

Downloading the release and copying over the driver manually does work, maybe the readme needs to mention this?

ian-h-chamberlain added a commit to ian-h-chamberlain/homebrew-cask that referenced this issue Dec 16, 2023
Fixes briankendall/proxy-audio-device#13

This change does a few things to fix the installation of
proxy-audio-device, based on the README for installation:

https://github.com/briankendall/proxy-audio-device#manual-installation

- Install the audio driver to `/Libary/Audio/Plug-Ins/HAL`
- Kickstart `coreaudiod` on install and uninstall for the device to be
  available
- zap saved application state for the settings app
@ian-h-chamberlain
Copy link

Homebrew/homebrew-cask#162690 has just been merged, which I believe should fix this issue (I think auto-close didn't work since it's in a different repo). It would be great if some other people could test it and verify the fix, after which I think this issue can be closed?

@mahmoudhossam
Copy link

I tried it today and it seems to do the right thing on my system.

I'd prefer if it gave more details on this Changing ownership of paths required by proxy-audio-device with sudo; the password may be necessary. as first-time installers might not have the necessary permissions set already.

@ian-h-chamberlain
Copy link

ian-h-chamberlain commented Dec 18, 2023

That message comes from brew itself, but you can see more details about what it's doing with --verbose --debug:

==> Changing ownership of paths required by proxy-audio-device with sudo; the password may be necessary.
/usr/bin/sudo -E -- /usr/sbin/chown -R -- root:wheel /Library/Audio/Plug-Ins/HAL/ProxyAudioDevice.driver
/usr/bin/sudo -E -- /bin/launchctl kickstart -k system/com.apple.audio.coreaudiod
==> Installing artifact of class Cask::Artifact::PostflightBlock
🍺  proxy-audio-device was successfully installed!

@Odame or @briankendall it seems like this is fixed now, would one of you like to close the issue?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants