Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup #38

Open
LeoMcA opened this issue Jan 12, 2015 · 3 comments
Open

Cleanup #38

LeoMcA opened this issue Jan 12, 2015 · 3 comments
Assignees

Comments

@LeoMcA
Copy link
Collaborator

LeoMcA commented Jan 12, 2015

The code feels rather messy since half the files seem to be for (what seems to me to be) a non-existent phonegap application. Furthermore, there's inconsistent tabulation/spacing and code style throughout, and dependencies we don't actually use.

I definitely think the phonegap code should go, and instead we should have an Open Web App/Firefox OS App.

I'm not sure whether keeping both in the same repository or having a repo for the add-on, a repo for the webapp, and a repo for the common elements between the two (which is then git submoduled, or included in the other repos by some other means) makes the most sense.

Thoughts?

@brianking
Copy link
Owner

I'd be happy if the code was cleaned up. As for the phonegap code, any libraries I used I just took them whole and added. One thing we have to watch for is that libraries are checksum compared with standard releases during the AMO review process, so I am not sure if removing files affects this.

I will defer to you on the proposal of separating out code.

@MichaelKohler
Copy link
Contributor

sounds good to me, go for it! :) also, maybe we can host this on the Mozilla GitHub account? (like that we might get more attention for bugfixes)

@LeoMcA
Copy link
Collaborator Author

LeoMcA commented Jan 12, 2015

Okay - I'll work on cleaning up and removing anything not relevant to the add-on in a cleanup branch. Then, once it's 'clean', I'll make the decision (or we can discuss further) how best to make a FxOS app out of it. (And pull back any potentially relevant code from master into wherever that lives, before merging.)

@MichaelKohler Mozilla GitHub would be cool, but I'm not sure who makes the call on that. IIRC there needs to be a common admin on this repo and on the Mozilla GitHub account to make the transfer.

LeoMcA added a commit to LeoMcA/ReMo-Helper that referenced this issue Jan 18, 2015
LeoMcA added a commit to LeoMcA/ReMo-Helper that referenced this issue Jan 18, 2015
LeoMcA added a commit to LeoMcA/ReMo-Helper that referenced this issue Jan 18, 2015
LeoMcA added a commit to LeoMcA/ReMo-Helper that referenced this issue Jan 18, 2015
LeoMcA added a commit to LeoMcA/ReMo-Helper that referenced this issue Jan 18, 2015
LeoMcA added a commit to LeoMcA/ReMo-Helper that referenced this issue Feb 13, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants