Issue 11

[erikvold]

No description provided.

[brianking]

protocol is not resolving:

$ cfx run
Traceback (most recent call last):
File "c:/mozilla/addon-sdk/addon-sdk-1.7/bin/cfx", line 33, in
cuddlefish.run()
File "c:\mozilla\addon-sdk\addon-sdk-1.7\python-lib\cuddlefish__init__.py", l
ine 626, in run
deps = packaging.get_deps_for_targets(pkg_cfg, targets)
File "c:\mozilla\addon-sdk\addon-sdk-1.7\python-lib\cuddlefish\packaging.py",
line 275, in get_deps_for_targets
raise PackageNotFoundError(dep, required_reason)
cuddlefish.packaging.PackageNotFoundError: protocol (required by 'remo-companion
')
(addon-sdk-1.7)

[erikvold]

this guide explains a little about how to use 3rd party modules

protocol is here. I usually clone the repo to ~/github/ then ln -s ~/github/protocol protocol from the packages folder of my sdk clone.

[brianking]

Oh I see. So does that do a copy, and will 'cfx xpi' then bundle it?

Also, that will be flagged by the AMO validator I am sure as not being a core SDK file.

[erikvold]

yes and yes.

[brianking]

Thanks, works now.

This checkin has caused 1 regression. I have filed issue #18 for it.

[brianking]

Can about: pages have a favicon I wonder?

[erikvold]

I just tried adding a favicon with <link rel="icon" type="image/jpg" href="..."> and that worked.

[brianking]

Seems like protocol is broken in 1.8:

Gozala/jetpack-protocol#5

[erikvold]

hmm it looks like this lib is going to be part of the sdk mozilla/addon-sdk#290

We may still need to work around the 1.8 issue tho..

I'll ask @Gozala about it.

[Gozala]

If someone want's to send in pull request I'd be happy to accept. The problem is module wrapper here: https://github.com/Gozala/jetpack-protocol/blob/master/selfish.js#L6