[Bug] Delay fix, round down hour #70
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Generalized method of rounding to fit lower intervals.
|
Seems to be functioning as intended. Will give it another day and then merge if everything is good. |
|
Hi @brianleect , I left you a message in the original post but it's closed. If you have the opportunity to review it, I appreciate it. Cheers |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #66
Original suggestion was to restart at fixed intervals but it would lead to missing gaps of data that would not be easily resolved without additional complexity.
After some thought, considering delay due to message sending over time will always result in a message being sent later, a simple fix would just to constantly round down to the nearest hour while setting time for last trigger.
Will run this version and see if it resolves the TDPA delays before sending.