Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor lexer #2

Merged
merged 2 commits into from Jun 6, 2019
Merged

Refactor lexer #2

merged 2 commits into from Jun 6, 2019

Conversation

pyrmont
Copy link

@pyrmont pyrmont commented Jun 5, 2019

This PR demonstrates how the lexer could be simplified while producing the same results.

@pyrmont pyrmont mentioned this pull request Jun 5, 2019
Merged
@pyrmont
Copy link
Author

pyrmont commented Jun 5, 2019 •
edited

@brianlheim Can you update the visual spec to cover the edge cases that @jneen identified in her review (here and here)? I'm not completely confident about my understanding of SuperCollider to feel comfortable doing that.

@mossheim mossheim merged commit badb24f into mossheim:lexer/supercollider Jun 6, 2019
@mossheim
Copy link
Owner

mossheim commented Jun 6, 2019

@jneen @pyrmont Thanks! I rebased this on my branch and pushed the visual spec update to rouge-ruby#749.

@pyrmont pyrmont deleted the prfix.pr-749 branch January 8, 2020 20:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jneen jneen jneen left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@pyrmont @mossheim @jneen