Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not publish global typings to npm #20

Closed
demurgos opened this issue Jun 27, 2017 · 3 comments
Closed

Do not publish global typings to npm #20

demurgos opened this issue Jun 27, 2017 · 3 comments

Comments

@demurgos
Copy link

Hi,
Your package publishes global typings to npm. This causes conflicts with other (and more recent / acurate) definitions for Node. This module is simply unusable with full TS checks.

Since you use typings, you shouldn't even publish your typings directory but let typings resolve the dependencies with your typings.json file. typings is now deprecated in favor of @types, I'd recommend to switch to @types while fixing this issue.

@alexbjorlig
Copy link

alexbjorlig commented Nov 8, 2017

Hi @demurgos - how do you solve this in your project? I solved it by adding the following gulp task to my project:

gulp.task('clean-script', function(){
return del([
        'node_modules/base64url/typings',
        'node_modules/base64url/dist/base64url.d.ts',          
    ]);
});

@demurgos
Copy link
Author

demurgos commented Nov 8, 2017

@dauledk
I don't have time to deal with these sorts of issues and even if your solution could work in a postinstall hook, it remains a hack.
This issue is so bad that I just switched to another lib: base64-url (with a dash).

@brianloveswords Since I switched to another lib, I did not follow this issue actively, but it seems that multiple other people upvoted this issue. I appreciate that you tried to provide type definitions, but it's been 4 months that your library is unusable with Typescript. Please consider one of the solutions I mentioned in the first post.

@MylesBorins
Copy link
Collaborator

We believe that this was fixed in 3.0.0. Please let us know if that is incorrect and we'll re-open the PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants