New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use base64-url instead of base64url for TypeScript support. #20

Closed

kevmo314 wants to merge 2 commits into Brightspace:master from kevmo314:master

kevmo314 commented Apr 6, 2018

The base64url package has issues with TypeScript and there are a number of pull requests to fix it, but the package author seems to have abandoned the package.

This change switches to base64-url instead, which does not have this issue but is functionally identical.


          Use base64-url instead of base64url for TypeScript support.

9a200fb

kevmo314 requested a review from omsmith as a code owner

April 6, 2018 01:04


          Remove base64url dependency.

6e17a4a

coveralls commented Apr 6, 2018 •

edited

Coverage remained the same at 99.057% when pulling 6e17a4a on kevmo314:master into 8270f01 on Brightspace:master.

coveralls commented Apr 6, 2018 •

edited

Coverage remained the same at 99.057% when pulling 6e17a4a on kevmo314:master into 8270f01 on Brightspace:master.

coveralls commented Apr 6, 2018

Coverage remained the same at 99.057% when pulling 6e17a4a on kevmo314:master into 8270f01 on Brightspace:master.

1 similar comment

coveralls commented Apr 6, 2018

Coverage remained the same at 99.057% when pulling 6e17a4a on kevmo314:master into 8270f01 on Brightspace:master.

coveralls commented Apr 6, 2018

Coverage remained the same at 99.057% when pulling 6e17a4a on kevmo314:master into 8270f01 on Brightspace:master.

Author

kevmo314 commented Apr 6, 2018

Alternatively, since it seems like @omsmith you're the de facto owner of a lot of these packages, do you have authority to just merge this PR, which would solve the issue more easily instead of migrating every single dependency over to base64-url?

Contributor

omsmith commented May 14, 2018

Hey - I've removed the dependency on base64url in favour of an inline definition for now so that we can maintain version support.

Author

kevmo314 commented May 14, 2018

Cool, thank you!

kevmo314 closed this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment