Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ASCII Readme #25

Closed
wants to merge 1 commit into from
Closed

ASCII Readme #25

wants to merge 1 commit into from

Conversation

notpeter
Copy link

@notpeter notpeter commented Oct 24, 2016

Currently setup.py pulls in the long description from the README.md: (long_description=read('README.md')

Sadly, because you have unicode emdashes ("\xe2\x80\x93" instead of "--") in the readme.md python will fail trying to stringify those characters and error with:

Collecting jws>=0.1.3 (from python_jwt==1.1.0->-r /tmp/tmpEbDt97/requirements.txt (line 27))
  Downloading jws-0.1.3.tar.gz
    Complete output from command python setup.py egg_info:
    Traceback (most recent call last):
      File "<string>", line 1, in <module>
      File "/tmp/pip-build-db5dsmc7/jws/setup.py", line 17, in <module>
        long_description=read('README.md'),
      File "/tmp/pip-build-db5dsmc7/jws/setup.py", line 5, in read
        return open(os.path.join(os.path.dirname(__file__), fname)).read()
      File "/venv3/lib/python3.5/encodings/ascii.py", line 26, in decode
        return codecs.ascii_decode(input, self.errors)[0]
    UnicodeDecodeError: 'ascii' codec can't decode byte 0xe2 in position 500: ordinal not in range(128)

To reproduce, under Python 3.5 run: LC_CTYPE=C pip3 install jws

This fixes this, but it would require a subsequent point release (0.1.4) to actually to keep it from happening on future pip installs.

@notpeter
Copy link
Author

I just noticed this is the same issue fixed in #21.

@graingert
Copy link

@brianloveswords ping

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants