Add scriptFile parameter to allow users to specify the script that gets embedded #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…y the script that gets embedded.
brianm
added a commit
that referenced
this pull request
Sep 17, 2013
Add scriptFile parameter to allow users to specify the script that gets embedded
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the plugin has a fairly basic script that it injects which doesn't allow for things like overriding jvm parameters from the command-line. It would be nice to have the ability to override such things, but it's not safe to assume that everyone will want it done the same way.
Instead of picking how it should be done, giving users the ability to specify the script that they want embedded seemed like the safest solution with minimal impact.