Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify Rails 4.2.11 support in Readme #1131

Merged
merged 1 commit into from Aug 5, 2020
Merged

Conversation

muzfuz
Copy link
Contributor

@muzfuz muzfuz commented Aug 5, 2020

The README states that rails 4.2 does not support version 0.5 of the gem, however, as indicated by this comment and this release, Rails 4.2.11 does actually support 0.5.

This caused a bit of confusion at our end during the upgrade of a legacy app, as all tests seemed to pass even though the docs indicated otherwise.

I hope this small change is useful for someone in a similar situation. Thank you 馃槃

@muzfuz muzfuz marked this pull request as ready for review August 5, 2020 17:15
@sodabrew
Copy link
Collaborator

sodabrew commented Aug 5, 2020

Thank you!

@sodabrew sodabrew merged commit 05bbe75 into brianmario:master Aug 5, 2020
@muzfuz muzfuz deleted the patch-1 branch August 6, 2020 09:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants