Run GC.verify_compaction_references on CI #1155
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the PR! I see the following error on Ruby 3.0 case. https://travis-ci.org/github/brianmario/mysql2/jobs/756060952 Perhaps, it's not |
No, that's the same thing in YAML. It might be a travis bug. Either way travis is shutting down soon, might be a good idea to migrate to GitHub Actions. |
casperisfine
force-pushed
the
verify-compaction-references
branch
from
84f5c5e
to
c034285
Compare
|
Since #1154 just landed to switch from Travis to Github Actions, could you rebase so we can see this run on GHA? |
|
sure |
casperisfine
force-pushed
the
verify-compaction-references
branch
from
c034285
to
150521d
Compare
casperisfine
force-pushed
the
verify-compaction-references
branch
from
150521d
to
8d4e741
Compare
|
Ok, same failures than on master, which I suppose is a success? |
|
Yep! Looks like the expected-to-pass tests pass and the expected-to-fail ones fail. Looks good to merge! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a followup to #1115
In 3.0 a new API was introduced that ask the GC to move all objects. This is useful to test for bugs like the ones that were fixed in #1115.
cc @sodabrew