Refactor CI yaml files #1176
Merged
Refactor CI yaml files #1176
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As the CentOS 7 system Ruby is the fixed version 2.0.0, we can remove the Ruby 2.0.0 case in Travis. Remove `sudo: required` syntax in Travis, as the key `sudo` is deprecated and it has no effect anymore according to the Travis "View config" page.
|
@sodabrew Could you take a look this PR? |
|
My concern is the Ruby 2.0.0 installed on Travis ubuntu by RVM, and installed as a RPM package on CentOS 7 are possibly a little different. At least I can predict that Ruby 2.0.0 on CentOS is applying many patch files in it. I am a little negative to remove Ruby 2.0.0 on Travis now. |
|
Thanks for checking and merging! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are 3 commits on this PR to refactor the CI yaml files.
Fix wrong comments.
The comments for the 2 cases were actually opposite.
GitHub Actions: Set the default value to allow-failure.
There is a way to omit the
allow-failurewhen the case passes setting the default value. The tip is inspired by the rspec-core's GitHub Actions yaml file.Migrate Ruby 2.0.0 case in Travis to GitHub Actions.
We have actually Ruby 2.0.0 case on CentOS 7 case. I know the system Ruby in CentOS 7 is 2.0.0 until the CentOS 7 will be end of life. The tip using
name_extraalso comes from the rspec-core's GitHub Actions yaml file.I thought we could remove the Ruby 2.0.0 case in Travis CI. In other words, we may still want to keep the Ruby 2.0.0 in Travis for some reasons.
What do you think?