Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix parsing bad surrogate trailers #177

Closed
wants to merge 2 commits into from
Closed

Fix parsing bad surrogate trailers #177

wants to merge 2 commits into from

Commits on Nov 7, 2017

  1. Fix parsing bad surrogate trailers 

    If a valid surrogate character escape is found, but the following
byte sequence isn't a valid unicode escape sequence, insert our
replacement character '?' as we would any other place we saw
invalid characters while unescaping.

Fixes #176
    @brianmario
    brianmario committed Nov 7, 2017
    Configuration menu
    Copy the full SHA
    0dc68aa View commit details
    Browse the repository at this point in the history

  2. Don't advance our end pointer until we've checked we have enough 

    buffer left and have peeked ahead to see that a unicode escape
is approaching.

Thanks @kivikakk for helping me track down the actual bug here!
    @brianmario
    brianmario committed Nov 7, 2017
    Configuration menu
    Copy the full SHA
    85701fc View commit details
    Browse the repository at this point in the history