Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Translate Juice to fr #9

Closed
wants to merge 5 commits into from
Closed

Translate Juice to fr #9

wants to merge 5 commits into from

Conversation

bnoufel
Copy link
Contributor

@bnoufel bnoufel commented Dec 20, 2016

Hi,

I Have translate this app to FR

@brianmichel
Copy link
Owner

Wow this looks incredible! I believe that Apple recommends that the keys for all localizable strings actually be the project base language variant of the string so if a user has their computer in an unsupported locale they will at least see well constructed strings. So instead of

CHARGED="chargés";

I think we should have it say


"charged"="chargés";


and the same thing for the english keys (even though it might look a bit silly 😊) this way if a user has their laptop in say German they will at least see `charged` instead of `CHARGED`

Copy link
Owner

@brianmichel brianmichel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good minus the key changes mentioned in another comment.

@bnoufel
Copy link
Contributor Author

bnoufel commented Dec 21, 2016

Ok no problem,

I minus all the keys and finish option :)

Please tell me just how to get your bio in the app :)

thanks

@bnoufel
Copy link
Contributor Author

bnoufel commented Dec 21, 2016

I forget, i see a bug ,

If you change scale, emoji scale are not in place

Example if i change for "Roman Numerals", and i want again emoji, i do to choice "Dotted Line" :)

@brianmichel
Copy link
Owner

I forget, i see a bug ,

If you change scale, emoji scale are not in place

Example if i change for "Roman Numerals", and i want again emoji, i do to choice "Dotted Line" :)

Interesting, would you be able to file an issue with the steps to reproduce the problem please?

@brianmichel
Copy link
Owner

Please tell me just how to get your bio in the app :)

Ha! this was a screen i decided not to put in and will be deleting the code since I more easily could just write it in the README, I'll be deleting that code soon though, enjoy the picture of me lol

static let title = "title"
static let detents = "detents"
static let defaultDetentString = "default"
static let title = NSLocalizedString("title", comment: "title")
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These should not be localized as they are part of the plist serialization format.

@@ -1,4 +1,6 @@
![](/images/icon-readme.png)

Thanks to brianmichel, i just translate Juice to French people contact me for bug or other translate : contact@flayor.com
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we add a Contributors section to the end of the read me please? Also, I'm happy to acknowledge you for the work you've done on the project, but I do not want to have the contact email address as part of this projects README, but feel free to link to your github/twitter profile.

"General"="Général";
"General setting"="Réglage général";
"Credits"="Crédits";
//"Scales Found"="Skin trouvé";
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can this be deleted if it's not needed? Or should it not be commented out?

"General setting"="Réglage général";
"Credits"="Crédits";
//"Scales Found"="Skin trouvé";
"Error scanning application support directory"="Error scanning application support directory";
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This string does not seem to be translated.

"title"="titre";
"default"="Défaut";
"detents"="detents";
"Error serializing scale"="Error serializing scale";
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This string does not seem to be translated.

@bnoufel
Copy link
Contributor Author

bnoufel commented Dec 22, 2016

I have recreate an other project merge confilt, i open an other pull request.

For this bug ... this is strange i don't have this problem after reboot & maj Puice

@bnoufel bnoufel closed this Dec 22, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants