Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Translation tool] ja_JP #1603

Closed
atakigawa opened this issue Feb 23, 2019 · 1 comment
Closed

[Translation tool] ja_JP #1603

atakigawa opened this issue Feb 23, 2019 · 1 comment
Assignees
@kylekatarnls
Labels
translation Rely to internationalization
Milestone
2.14

Comments

@atakigawa
Copy link

English ja_JP comments
1 second 数秒 This should rather be 1秒 because 数 means "few"
@kylekatarnls
Copy link
Collaborator

Confirmed. I will fix this.

@kylekatarnls kylekatarnls self-assigned this Feb 24, 2019
@kylekatarnls kylekatarnls added the translation Rely to internationalization label Feb 24, 2019
@kylekatarnls kylekatarnls added this to the 2.14 milestone Feb 24, 2019
kylekatarnls added a commit to kylekatarnls/Carbon that referenced this issue Feb 25, 2019
@kylekatarnls
Fix briannesbitt#1603 Add aUnit option for seconds in Japanese
41c3331
@kylekatarnls kylekatarnls mentioned this issue Feb 25, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kylekatarnls kylekatarnls

Labels
translation Rely to internationalization
Projects
None yet
Milestone
2.14
Development

No branches or pull requests
2 participants
@atakigawa @kylekatarnls